Reject negative process grid dimensions#141
Merged
Merged
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
romerojosh
reviewed
Jun 17, 2026
romerojosh
left a comment
romerojosh
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution @fallintoplace! I've left a comment to address but otherwise this looks good. Definitely covering a rare edge case, but better to catch this user error than not.
Signed-off-by: Josh Romero <joshr@nvidia.com>
Collaborator
|
/build |
|
🚀 Build workflow triggered! View run |
|
✅ Build workflow passed! View run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject negative
pdimsvalues during grid descriptor validation before checking the process-grid product.Previously,
checkConfigonly used product semantics for explicit process grids, so a configuration such as[-2, -2]could pass on four ranks. The later process-grid indexing code assumes positive dimensions for division, modulo, communicator setup, and pencil decomposition.This also widens the product calculation to
int64_tso validation does not overflow before comparing with the rank count.Tests
git diff --checkpdimspairs whose product equals the test rank countLocal build/test execution was not available in this checkout because
clang-format,nvcc, andmpicxxare not installed.